fix: allow custom attributes for extensible types (#365)

OKTA-550323 fix: allow custom attributes for extensible types

CHANGELOG.md

@@ -4,8 +4,8 @@
 
 ### Bug Fixes
 
-- [#329](https://github.com/okta/okta-sdk-nodejs/pull/360) Fixes path and type signature issues for MemoryStore.
-
+- [#360](https://github.com/okta/okta-sdk-nodejs/pull/360) Fixes path and type signature issues for MemoryStore.
+- [#365](https://github.com/okta/okta-sdk-nodejs/pull/365) Adds support for custom attributes in UserProfile and GroupProfile
 
 # 6.5.0
 

src/types/custom-attributes.d.ts

@@ -0,0 +1,18 @@
+/*!
+ * Copyright (c) 2017-present, Okta, Inc. and/or its affiliates. All rights reserved.
+ * The Okta software accompanied by this notice is provided pursuant to the Apache License, Version 2.0 (the "License.")
+ *
+ * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and limitations under the License.
+ */
+
+
+type CustomAttributeValue = boolean | number | string;
+
+export {
+  CustomAttributeValue
+};

templates/model.d.ts.hbs

@@ -6,6 +6,9 @@ import { {{extends}} } from './{{extends}}';
 {{else}}
 import { Resource } from '../resource';
 {{/if}}
+{{#if this.isExtensible}}
+import { CustomAttributeValue } from '../custom-attributes';
+{{/if}}
 import { Client } from '../client';
 {{#if (shouldGenerateOptionsType modelName)}}
 {{#if properties.length}}
@@ -36,6 +39,9 @@ declare class {{modelName}} extends Resource {
 {{/if}}
 {{/unless}}
 {{/each}}
+{{#if this.isExtensible}}
+  [key: string]: CustomAttributeValue | CustomAttributeValue[]
+{{/if}}
 
   {{#each crud}}
   {{#if (eq alias 'update')}}

test/type/user-profile.test-d.ts

@@ -0,0 +1,10 @@
+import { expectType } from 'tsd';
+
+import { Client } from '../../src/types/client';
+import { CustomAttributeValue } from '../../src/types/custom-attributes';
+import { UserProfile } from './../../src/types/models/UserProfile.d';
+
+const client = new Client();
+const userProfile = new UserProfile({}, client);
+expectType<CustomAttributeValue | CustomAttributeValue[]>(userProfile.customAttribute);
+expectType<string>(userProfile.costCenter);

yarn.lock

@@ -4799,4 +4799,4 @@ z-schema@^4.2.2:
     lodash.isequal "^4.5.0"
     validator "^13.6.0"
   optionalDependencies:
-    commander "^2.7.1"
+    commander "^2.7.1"