Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetFilterChanges return a empty object instead of null when no changes. #242

Merged
merged 4 commits into from
Aug 12, 2024
Merged

GetFilterChanges return a empty object instead of null when no changes. #242

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bdd02c
if no blocks return object instead of null
giskook Aug 7, 2024
470870c
fix compile error
giskook Aug 7, 2024
6e4b8e1
logs return object instead of null
giskook Aug 11, 2024
165609e
return object install null
giskook Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jsonrpc/endpoints_eth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ func (e *EthEndpoints) GetFilterChanges(filterID string) (interface{}, types.Err
return nil, rpcErr
}
if len(res) == 0 {
return nil, nil
return []common.Hash{}, nil
giskook marked this conversation as resolved.
Show resolved Hide resolved
}
return res, nil
}
Expand All @@ -488,7 +488,7 @@ func (e *EthEndpoints) GetFilterChanges(filterID string) (interface{}, types.Err
return nil, rpcErr
}
if len(res) == 0 {
return nil, nil
return []common.Hash{}, nil
}
return res, nil
}
Expand All @@ -511,7 +511,7 @@ func (e *EthEndpoints) GetFilterChanges(filterID string) (interface{}, types.Err
}
res := resInterface.([]types.Log)
if len(res) == 0 {
return nil, nil
return []types.Log{}, nil
}
return res, nil
}
Expand Down
Loading