Fix dt items for tames #5684
Open
Fix dt items for tames #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Muspah also uses the effect for charged ice if you wanted to add that in aswell. I haven't had time to fix it but your PR looks alot better than my solution here: #5578 Vlad draken loot is still an issue aswell if you wanted to look at Magna's feedback. No worries if not, I can always just piggy back off your work here. |
|
sorry closed the wrong one |
gc
reviewed
May 2, 2024
| @@ -113,8 +113,9 @@ export interface KillableMonster { | |||
| effect?: (opts: { | |||
| messages: string[]; | |||
| user: MUser; | |||
| tame?: Tame; | |||
There was a problem hiding this comment.
Change to use MTame, so you can do tame.totalLoot instead of new Bank(tame.max_total_loot as ItemBank). Merge at your discretion when its ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes DT one-of drops for tames
Changes:
updates tames to call effects and pass it's CL
Other checks: