Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning Scroll #6121

Open
wants to merge 2 commits into
base: bso
Choose a base branch
from
Open

Cleaning Scroll #6121

wants to merge 2 commits into from

Conversation

Felris
Copy link
Contributor

@Felris Felris commented Oct 14, 2024

Description:

Scroll of Cleansing was added with dungeoneering 3 years ago, and was never given a use. This use isn't too OP, but makes it do something a little useful at least. Scroll of cleansing saves 10% of secondaries for /mix command. Also added a /data to track how much the scroll has saved.

Changes:

src/mahoji/commands/mix.ts - Add a check for scroll of cleansing, and if found removes 10%(rounded down) of secondaries (using the secondaries filterable). Then updates cleansing_scroll_bank, and appends a short message saying the scroll of cleansing saved ingredients.

Other checks:

I've gone through the list of secondaries to make sure it's not too crazy anywhere, and I think it should be fine. The big items it saves are:
Abyssal Dragon bones and Ignecarus scales for dragons fury (But 10% saved is very minor)
Crushed superior dragon bones (Used in super anti-fires which are used in heat res pots)
Divine water for enhanced pots (again I don't think the 10% saved will change much)
Heat Res Vials are considered a secondary (But again, don't think it would change much)

  • [ x] I have tested all my changes thoroughly.

@github-actions github-actions bot added the BSO Bot School Old label Oct 14, 2024
@gc
Copy link
Collaborator

gc commented Oct 27, 2024

Just to comment, I'm unsure if this is the best use of the item, or the best place a perk like this should come from - although there's nothing wrong with your PR. So the PR is on a "thinking about it" status for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSO Bot School Old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants