Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchdnn brgemm validation enablement on aarch64 #1890

Merged
merged 13 commits into from
May 9, 2024

Conversation

Shreyas-fuj
Copy link
Contributor

Description

This PR contains enablement of benchdnn brgemm validation for aarch64(Previously it was available only for x86).

Major code changes:
In the following files the namespace has been modified to automatically select aarch64/x64 based on the cpu:

  1. oneDNN/tests/benchdnn/brgemm/bench_brgemm.cpp
  2. oneDNN/tests/benchdnn/brgemm/brgemm.cpp
  3. oneDNN/tests/benchdnn/brgemm/brgemm.hpp
  4. oneDNN/tests/benchdnn/brgemm/ref_brgemm.cpp

General

  • [yes] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  1. make test
98% tests passed, 3 tests failed out of 164

Total Test time (real) = 111.94 sec

The following tests FAILED:
         84 - test_shuffle (Subprocess aborted)
        146 - test_graph_unit_dnnl_conv_usm_cpu (Failed)
        151 - test_graph_unit_dnnl_large_partition_usm_cpu (Failed)
Errors while running CTest
Output from these tests are in: /home/shreyas/G/shr-fuj/oneDNN_open_source/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
make: *** [Makefile:71: test] Error 8
  1. make test_benchdnn_modeC_brgemm_ci_cpu/fast
tests:67008 passed:12288 skipped:54720 mistrusted:0 unimplemented:0 invalid_arguments:0 failed:0 listed:0
total: 78.41s; fill: 23.68s (30%); compute_ref: 13.79s (18%); compare: 8.51s (11%);
  • [yes] Have you formatted the code using clang-format?

src/cpu/aarch64/cpu_isa_traits.hpp Outdated Show resolved Hide resolved
tests/benchdnn/brgemm/brgemm.cpp Outdated Show resolved Hide resolved
tests/benchdnn/brgemm/brgemm.cpp Show resolved Hide resolved
tests/benchdnn/brgemm/brgemm.cpp Outdated Show resolved Hide resolved
tests/benchdnn/brgemm/ref_brgemm.cpp Outdated Show resolved Hide resolved
tests/benchdnn/brgemm/brgemm.hpp Outdated Show resolved Hide resolved
tests/benchdnn/brgemm/ref_brgemm.cpp Outdated Show resolved Hide resolved
@Shreyas-fuj
Copy link
Contributor Author

Hi @dzarukin , all changes have been accommodated. Thanks.

@dzarukin
Copy link
Contributor

dzarukin commented May 6, 2024

Hi @dzarukin , all changes have been accommodated. Thanks.

Just one left and you are good to get in. :)

@Shreyas-fuj
Copy link
Contributor Author

Shreyas-fuj commented May 7, 2024

Hi @dzarukin, is there anything still pending to be done from our side?

@vpirogov vpirogov added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label May 8, 2024
@dzarukin dzarukin merged commit 0163d0d into oneapi-src:main May 9, 2024
1 of 10 checks passed
@dzarukin
Copy link
Contributor

dzarukin commented May 9, 2024

Thank you for the contribution.

@vpirogov vpirogov added this to the v3.6 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants