cpu: reorder: use jit uni reorder for bf16 #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks for the PR. Tagging @jondea |
mgouicem
requested review from
dzarukin and
jondea
and removed request for
dzarukin
mgouicem
added
the
platform:cpu-aarch64
|
Thanks @mgouicem I'm sorting this now with @Ryo-not-rio |
add restriction for bf16 use when beta == 0.f as it is unsupported use jit uni reorder for aarch64 src=bf16 and dst=bf16
Ryo-not-rio
force-pushed
the
bf16-reorder-2
branch
from
caca13a
to
1d0734f
Compare
|
Sorry for the duplicate PR, unfortunately we couldn't reopen the original because it had been force pushed. Not sure why GitHub makes that restriction. |
|
No Problem at all. Just wanted to have your input on this PR and if you ran your internal validation on that. |
|
Hi @mgouicem, I'm a member of the same team as Jonathan and we have run the validation tests |
jondea
approved these changes
May 15, 2024
mgouicem
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use jit uni reorder for aarch64 src=bf16 and dst=bf16
add restriction for bf16 use when beta == 0.f as it is unsupported
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Performance improvements
CLIP model inference was 2x faster on PyTorch with this patch