Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC API in CUDA provider #807

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Oct 17, 2024

Description

Implement IPC API in CUDA provider.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@vinser52 vinser52 requested review from ldorau and bratpiorka October 17, 2024 16:06
@vinser52 vinser52 changed the title Svinogra ipc cuda IPC API in CUDA provider Oct 17, 2024
@vinser52 vinser52 force-pushed the svinogra_ipc_cuda branch 6 times, most recently from 6b377f0 to 068342d Compare October 18, 2024 21:55
@vinser52 vinser52 mentioned this pull request Oct 18, 2024
3 tasks
@vinser52 vinser52 force-pushed the svinogra_ipc_cuda branch 2 times, most recently from 57f1276 to 93f70d8 Compare October 22, 2024 13:40
@vinser52 vinser52 marked this pull request as ready for review October 22, 2024 13:40
@vinser52 vinser52 requested a review from a team as a code owner October 22, 2024 13:40
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov.sh Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_common.c Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_common.h Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_common.c Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_consumer.c Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_producer.c Outdated Show resolved Hide resolved
@vinser52 vinser52 force-pushed the svinogra_ipc_cuda branch 2 times, most recently from 15e313a to 1ca9d56 Compare October 22, 2024 21:10
@bratpiorka bratpiorka self-requested a review October 23, 2024 09:40
@vinser52 vinser52 requested a review from lplewa October 23, 2024 15:51
@bratpiorka
Copy link
Contributor

@vinser52 shouldn't you uncomment INSTANTIATE_TEST_SUITE_P(umfIpcTest) in test/providers/provider_cuda.cpp?

@vinser52
Copy link
Contributor Author

@vinser52 shouldn't you uncomment INSTANTIATE_TEST_SUITE_P(umfIpcTest) in test/providers/provider_cuda.cpp?

I tried to do that, but CUDA cuIpcOpenMemHandle API is more restrictive comparing to L0. It does not allow (as I understand) to open IPC handle in the same context, but tests in ipcFixture.hpp use the same context.

So, in a separate PR, we can enable the abovementioned tests when we resolve the issue I described. It looks like ipcFixture.hpp should be changed to use different GPU contexts.

test/providers/ipc_cuda_prov_consumer.c Outdated Show resolved Hide resolved
test/providers/ipc_cuda_prov_producer.c Outdated Show resolved Hide resolved
@bratpiorka
Copy link
Contributor

@vinser52 shouldn't you uncomment INSTANTIATE_TEST_SUITE_P(umfIpcTest) in test/providers/provider_cuda.cpp?

I tried to do that, but CUDA cuIpcOpenMemHandle API is more restrictive comparing to L0. It does not allow (as I understand) to open IPC handle in the same context, but tests in ipcFixture.hpp use the same context.

So, in a separate PR, we can enable the abovementioned tests when we resolve the issue I described. It looks like ipcFixture.hpp should be changed to use different GPU contexts.

ok I added an issue about this: #836

@bratpiorka bratpiorka merged commit b3bbdd4 into oneapi-src:main Oct 28, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants