Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTL: Add a CTL sources to the UMF #913

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+950 −2
Open

CTL: Add a CTL sources to the UMF #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888ab64
Move PMDK CTL sources
KFilipek Dec 12, 2024
ab2a19c
[CMake] Disable pedantic mode and disable cast qualifier warning
KFilipek Dec 12, 2024
05db80c
CTL: Add a CTL functionality to the UMF
KFilipek Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmake/helpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,8 @@ function(add_umf_target_compile_options name)
PRIVATE -fPIC
-Wall
-Wextra
-Wpedantic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you want to add this change in this PR, it should be in a sep. commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

-Wformat-security
-Wcast-qual
-Wno-cast-qual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you disable this flag?

$<$<CXX_COMPILER_ID:GNU>:-fdiagnostics-color=auto>)
if(CMAKE_BUILD_TYPE STREQUAL "Release")
target_compile_definitions(${name} PRIVATE -D_FORTIFY_SOURCE=2)
Expand Down
3 changes: 3 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ add_subdirectory(coarse)

set(UMF_LIBS $<BUILD_INTERFACE:umf_utils> $<BUILD_INTERFACE:coarse>)

set(CTL_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/ctl/ctl.c)

if(LINUX)
set(BA_SOURCES ${BA_SOURCES}
${CMAKE_CURRENT_SOURCE_DIR}/base_alloc/base_alloc_linux.c)
Expand All @@ -45,6 +47,7 @@ set(HWLOC_DEPENDENT_SOURCES topology.c)

set(UMF_SOURCES
${BA_SOURCES}
${CTL_SOURCES}
libumf.c
ipc.c
ipc_cache.c
Expand Down
Loading
Loading