Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure with destructor order in CUDA params #940

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix failure with destructor order in CUDA params #940

merged 2 commits into from
Nov 27, 2024

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Nov 27, 2024 •
edited
Loading

Description

This should fix the following failure: https://github.com/oneapi-src/unified-memory-framework/actions/runs/12041220655/job/33590212027

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@vinser52 vinser52 requested a review from a team as a code owner November 27, 2024 10:10
@vinser52 vinser52 mentioned this pull request Nov 27, 2024
Closed
@vinser52 vinser52 requested a review from bratpiorka November 27, 2024 10:13
@vinser52 vinser52 force-pushed the svinogra_cuda_params branch from 171d356 to 67127a5 Compare November 27, 2024 11:00
@vinser52 vinser52 requested a review from ldorau November 27, 2024 11:49
@vinser52 vinser52 added the v0.10.x Should be included in stable branch v0.10.x label Nov 27, 2024
@bratpiorka
Copy link
Contributor

please fix also the Disjoint Pool

@vinser52
Copy link
Contributor Author

vinser52 commented Nov 27, 2024 •
edited
Loading

please fix also the Disjoint Pool

But disjoint pool is a static library today. I am not sure that it should call libumfInit. We should do that in the scope of #898.

I also added libumfInit scalable and jemalloc pools.

@vinser52 vinser52 force-pushed the svinogra_cuda_params branch from fa23dd8 to 109cc50 Compare November 27, 2024 13:10
@vinser52
Copy link
Contributor Author

please fix also the Disjoint Pool

But disjoint pool is a static library today. I am not sure that it should call libumfInit. We should do that in the scope of #898.

I also added libumfInit scalable and jemalloc pools.

jemalloc_pool is also a separate static library. So, added libumfInit only for scalable_pool

@ldorau ldorau merged commit 24e7119 into oneapi-src:main Nov 27, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@ldorau ldorau ldorau approved these changes

Assignees
No one assigned
Labels
v0.10.x Should be included in stable branch v0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinser52 @bratpiorka @ldorau