Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L0 provider: implement support for defer and blocking free #963

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

L0 provider: implement support for defer and blocking free #963

wants to merge 1 commit into from

Conversation

igchor
Copy link
Member

@igchor igchor commented Dec 4, 2024

Description

This feature is necessary to properly support urUSMFree for v2 L0 adapter.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@bratpiorka
Copy link
Contributor

@igchor do we need this for 0.10x / 2025.1?

@igchor
Copy link
Member Author

igchor commented Dec 5, 2024

@igchor do we need this for 0.10x / 2025.1?

No, for now I only want to use it for v2 L0 adapter which will not be released as part of 2025.1

@igchor igchor force-pushed the level_zero_provider_ext_free branch from 98b4e2a to 76672ed Compare December 5, 2024 15:27
@vinser52
Copy link
Contributor

vinser52 commented Dec 6, 2024

As a first step, I wanted to test this in UR (that's why I kept this as draft).

@igchor So we are not merging that till you confirm that UR works with the new UMF L0 config options and they do what UR needs?

@igchor
Copy link
Member Author

igchor commented Dec 6, 2024

As a first step, I wanted to test this in UR (that's why I kept this as draft).

@igchor So we are not merging that till you confirm that UR works with the new UMF L0 config options and they do what UR needs?

Yes, I'll undraft the PR once I manage to test this in UR

vinser52
vinser52 reviewed Dec 9, 2024
View reviewed changes
include/umf/providers/provider_level_zero.h
/// @param hParams handle to the parameters of the Level Zero Memory Provider.
/// @param policy memory free policy.
/// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
umf_result_t umfLevelZeroMemoryProviderParamsSetFreePolicy(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the src/libumf.def and src/libumf.map files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. and place this call in the proper set of exported functions (UMF_0.11?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I added it under UMF_0.11 scope but how do we want to do that for windows? In .def file we have a single VERSION specified.

@igchor igchor force-pushed the level_zero_provider_ext_free branch from 76672ed to bb2d469 Compare December 10, 2024 20:37
@igchor igchor force-pushed the level_zero_provider_ext_free branch from bb2d469 to 477edb6 Compare December 10, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@vinser52 vinser52 vinser52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igchor @bratpiorka @vinser52