add fixed provider #976
Open
add fixed provider #976
+815
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Dec 7, 2024
| @@ -0,0 +1,330 @@ | |||
| #include "base.hpp" | |||
There was a problem hiding this comment.
missing copyright
please keep system indludes first, then umf public API, then local
There was a problem hiding this comment.
copyright - added. An order of the includes are consistent with other provider tests. So unless we will fix it in all files, it should stay the same
PatKamin
reviewed
Dec 9, 2024
vinser52
reviewed
Dec 9, 2024
ldorau
reviewed
Dec 9, 2024
3 tasks
|
#981 has been merged. Rebase please. |
bratpiorka
reviewed
Dec 11, 2024
| umfFileMemoryProviderOps | ||
| umfFileMemoryProviderParamsCreate | ||
| umfFileMemoryProviderParamsDestroy | ||
| umfFileMemoryProviderParamsSetPath | ||
| umfFileMemoryProviderParamsSetProtection | ||
| umfFileMemoryProviderParamsSetVisibility | ||
| umfFixedMemoryProviderOps |
There was a problem hiding this comment.
please add new functions to LIBUMF_0.11 set (requires #974 merged + rebase)
There was a problem hiding this comment.
if it will be merged....
lplewa
force-pushed
the
fixed
branch
4 times, most recently
from
e9f92ca to
4e91bc9
Compare
ldorau
approved these changes
Dec 13, 2024
PatKamin
reviewed
Dec 13, 2024
PatKamin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist