Add the get_umf_debug_info.sh script to print saved strings
#993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
6a5b72a to
19f847b
Compare
There was a problem hiding this comment.
perhaps we should wait with this for #992 and re-base it to v0.10.x ?
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
19f847b to
ab1f260
Compare
Rebased |
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
ab1f260 to
bd6b240
Compare
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
2 times, most recently
from
9c5807f to
2bf2c08
Compare
|
@bratpiorka @lukaszstolarczuk please review |
lukaszstolarczuk
previously approved these changes
Dec 12, 2024
|
Do we need this script in repo? What is an usecase? This is literally debug feature, that anyone with basic skills should use without helper scripts. |
I think it could be useful on our other repos; it's just a script 😉 |
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
2bf2c08 to
dbacb0e
Compare
|
@bratpiorka please review |
PatKamin
reviewed
Dec 13, 2024
It can be useful in retrieving a complete information on the build used by someone who filed a bug. It's easier to just ask to run this script than explaining what packages one needs and what to grep for each time, I think. |
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
dbacb0e to
b5e23b0
Compare
PatKamin
approved these changes
Dec 13, 2024
lukaszstolarczuk
requested changes
Dec 13, 2024
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
b5e23b0 to
9717f3b
Compare
Add the `get_umf_debug_info.sh` script to print saved strings. It can be used with any user binary: $ scripts/get_umf_debug_info.sh ./build/test/umf_test-base ./build/test/umf_test-base does not contain magic strings of the UMF library. $ scripts/get_umf_debug_info.sh ./build/test/umf_test-ipc ./build/test/umf_test-ipc is statically linked with the UMF library. Strings in /mnt/wsl/files/repos/unified-memory-framework/build/test/umf_test-ipc: @(#) Intel(R) UMF version: 0.10.0-git4.gbf701ee8 @(#) Intel(R) UMF CMake variables: "CMAKE_BUILD_TYPE:Debug, ..." $ scripts/get_umf_debug_info.sh ./build/test/umf_test-c_api_disjoint_pool ./build/test/umf_test-c_api_disjoint_pool is dynamically linked with the UMF library \ (/mnt/wsl/files/repos/unified-memory-framework/build/lib/libumf.so.0.10.0). Strings in /mnt/wsl/files/repos/unified-memory-framework/build/lib/libumf.so.0.10.0: @(#) Intel(R) UMF version: 0.10.0-git4.gbf701ee8 @(#) Intel(R) UMF CMake variables: "CMAKE_BUILD_TYPE:Debug, ..." $ scripts/get_umf_debug_info.sh ./build/lib/libumf.so ./build/lib/libumf.so is the UMF library (/mnt/wsl/files/repos/unified-memory-framework/build/lib/libumf.so.0.10.0). Strings in /mnt/wsl/files/repos/unified-memory-framework/build/lib/libumf.so.0.10.0: @(#) Intel(R) UMF version: 0.10.0-git4.g806ce00c @(#) Intel(R) UMF CMake variables: "CMAKE_BUILD_TYPE:Debug, ..." Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_get_umf_debug_info.sh_to_print_saved_strings
branch
from
9717f3b to
b3d87e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
get_umf_debug_info.shscript to print saved strings.It can be used with any user binary:
Checklist