Fix #336 add symfony/serializer 6 support #367
Conversation
GinoPane
changed the title
|
@gep hi! Do you mind to review the PR? Thank you |
I already reviewed. Thanks |
|
Oh, @gep sorry for inconvenience, thought that you are the developer of the package |
|
@84m hi! Could you review changes of the PR? Thanks |
| @@ -27,7 +27,7 @@ class AggregationsEndpoint extends AbstractSearchEndpoint | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function normalize(NormalizerInterface $normalizer, string $format = null, array $context = []) | |||
| public function normalize(NormalizerInterface $normalizer, string $format = null, array $context = []): array|string|int|float|bool | |||
There was a problem hiding this comment.
Union return types are from php 8 and in composer we declare that php 7.4 is supported.
There was a problem hiding this comment.
I think it's time to remove 7.4 as it's no longer supported :(
https://www.php.net/supported-versions.php
Or we can return nothing in this function
|
Any update on when this will get merged? I've hardcoded this pull request so long into my composer. |
|
You can use fork with updated PHP and serializer https://github.com/bistrosk/elasticsearch-dsl. |
No description provided.