Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): ocaml -> 4.11 #3531

Merged
merged 5 commits into from
May 12, 2021
Merged

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented May 11, 2021

Gotta get Onivim caught up with: revery-ui/revery#1066

This also will let us start using memtrace (since 4.11 has the Gc.Memprof apis) which will be really helpful for perf: https://github.com/janestreet/memtrace

@EduardoRFS
Copy link

@bryphe why not a 4.12? 4.11 doesn't support macOS ARM64 while 4.12 and 4.10.2 do.

And at least for building OCaml the differences between native ARM64 and Rosetta emulation is huge.

@bryphe
Copy link
Member Author

bryphe commented May 12, 2021

@bryphe why not a 4.12? 4.11 doesn't support macOS ARM64 while 4.12 and 4.10.2 do.

Good question @EduardoRFS - primarily to minimize risk - I like to take baby steps with critical dependencies like OCaml. Sometimes there can be surprises (a perf regression... a change in GC behavior that exposes a bug in our C FFI interop... packaging gets broken... etc).

I'll start a PR for 4.12 after this is in. Having the ARM build (#2708) is a good reason to not wait too long to bring in 4.12 👍 I didn't realize 4.11 doesn't support macOS ARM64...

@bryphe bryphe merged commit 1228d37 into master May 12, 2021
bryphe added a commit that referenced this pull request May 19, 2021
- Upgrade to OCaml 4.12 (following from #3531 )
- Pre-req for OSX ARM builds: #2708

Sounds like this will also fix #3489
@bryphe bryphe mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants