Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): OCaml -> 4.12, redux #3595

Merged
merged 8 commits into from
May 26, 2021

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented May 25, 2021

Retrying #3536

@zbaylin zbaylin requested a review from bryphe May 25, 2021 19:24
Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zbaylin ! Tested locally on Windows - haven't been able to reproduce a crash 🤞

@zbaylin
Copy link
Member Author

zbaylin commented May 25, 2021

Awesome @bryphe! I've been bumping up against that unqualified-id error which has prevented me from doing any development on Oni, so this should free me up again!

@bryphe
Copy link
Member

bryphe commented May 25, 2021

Weird, looks the CentOS failure might be related to the prebuilt DLLs:

info install 0.6.10 (using package.json)
error unable to fetch esy-skia@github:revery-ui/esy-skia#6106223:
                                                                   source: github:revery-ui/esy-skia#6106223
                                                                   error: 
                                                                   error: command failed: 'git' '-C' '/oni2/_esy/default/tmp/esy-fc9118' 'checkout' '6106223'
                                                                   stderr:
                                                                            error: Your local changes to the following files would be overwritten by checkout:
                                                                            	prebuilt/windows/skia.dll
                                                                            Please commit your changes or stash them before you switch branches.
                                                                            Aborting
                                                                            
                                                                   stdout:
                                                                            
                                                                    fetching dist: github:revery-ui/esy-skia#6106223
error: installation error
  fetching esy-skia@github:revery-ui/esy-skia#6106223

https://dev.azure.com/onivim/oni2/_build/results?buildId=16714&view=logs&j=e3ae384d-e199-50c7-2cb4-9ce0785e7448&t=575416f9-89fc-5369-7933-ebe25f02131f&l=25

@zbaylin zbaylin merged commit d6fb8ef into master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants