Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camp_solver.c #8

Merged
merged 5 commits into from
Jan 29, 2022
Merged

Update camp_solver.c #8

merged 5 commits into from
Jan 29, 2022

Conversation

cguzman95
Copy link
Collaborator

@cguzman95
Copy link
Collaborator Author

cguzman95 commented Jan 4, 2022

Seems it only fails test_MONARCH_2. This test is still relevant or it does not matter? @mattldawson

@mattldawson
Copy link
Collaborator

Seems it only fails test_MONARCH_2. This test is still relevant or it does not matter? @mattldawson

Yeah, it's still relevant. You might try other values for the scaling, although it looks like you've tried this already. If this is just a problem for profiling, can you just disable it when you're doing the profiling?

@mattldawson
Copy link
Collaborator

You could also try:

h_j *= 0.95 + 0.1 * iter / (double)GUESS_MAX_ITER;

This worked for me. I think the important part is that the scaling is not the same at each iteration.

@cguzman95
Copy link
Collaborator Author

Fine now

@mattldawson mattldawson merged commit a54b863 into main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants