Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doaa's blog post -> Fix alignment of Arabic text #924

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Nov 21, 2024

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)
    This PR fixes the alignment of Arabic text in Doaa's welcome blog post.

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 8afd1ab
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/673f8ebefd7b830008b75e10
😎 Deploy Preview https://deploy-preview-924--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NPDebs
Copy link
Collaborator Author

NPDebs commented Nov 21, 2024

@BatoolMM - Following your comment on #923, I have re-aligned the Arabic text. Please take a quick look when you can and let me know if this is good to merge. Thanks again for spotting this!

Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it's perfect, thank you so much @NPDebs!!

@NPDebs
Copy link
Collaborator Author

NPDebs commented Nov 22, 2024

Ah, now it's perfect like you, Batool. 😍🌹 Thanks a lot!

@NPDebs NPDebs merged commit 8ef5277 into open-life-science:main Nov 22, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants