Skip to content

Commit

Permalink
MCA/SSHMEM/UCX: moved DEVICE_NIC_MEM comment back to segment_create
Browse files Browse the repository at this point in the history
Signed-off-by: Roie Danino <[email protected]>
  • Loading branch information
roiedanino committed Sep 7, 2023
1 parent ce61ab5 commit 1577cec
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions oshmem/mca/sshmem/ucx/sshmem_ucx_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ segment_create_internal(map_segment_t *ds_buf, void *address, size_t size,

status = ucp_mem_map(spml->ucp_context, &mem_map_params, &mem_h);
if (UCS_OK != status) {
SSHMEM_ERROR("Failed to allocate DEVICE_NIC_MEM"
" - ucp_mem_map() failed: %s, fallback to host memory\n",
ucs_status_string(status));
SSHMEM_ERROR("ucp_mem_map() failed: %s\n", ucs_status_string(status));
rc = OSHMEM_ERROR;
goto out;
}
Expand Down Expand Up @@ -190,7 +188,10 @@ segment_create(map_segment_t *ds_buf,
ds_buf->alloc_hints = hint;
ds_buf->allocator = &sshmem_ucx_allocator;
return OSHMEM_SUCCESS;
}
} else {
SSHMEM_WARN("Failed to allocate DEVICE_NIC_MEM: %s, "
"fallback to host memory", ucs_status_string(status));
}
#else
SSHMEM_VERBOSE(1, "DEVICE_NIC_MEM hint ignored since UCX does not "
"support MEMORY_TYPE_RDMA");
Expand Down

0 comments on commit 1577cec

Please sign in to comment.