-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/fix same instance #12709
Topic/fix same instance #12709
Conversation
The prior version identified requests from the same communicator instead of instance. Signed-off-by: George Bosilca <[email protected]>
Somehow this has been missed during the MPI_Count upgrade of the collective API. Signed-off-by: George Bosilca <[email protected]>
@bosilca Does the alltoallv commit belong into this pr, or did it accidentally slip in? |
@edgargabriel you are right, they are not related. They were all discovered on the same session on a machine with limited access outside, it was easier to bundle everything in a single PR. |
@bosilca may I suggest that you at least spell this out in the pr description, that two different issues are tackled here? (In addition, I would also still be interested in the answer to my other question, whether this is more of an optimization vs. an actual bug fix) |
@edgargabriel sorry I missed your second question. It is a bug fix, the current code checks if the PML requests are issued on the same communicator instead of the same instance. |
@bosilca ok, sounds good, thank you. In that case I need to pull this pr also in into our internal repo :-) |
Multiple fixes again main: