portals4: use PtlHandleIsEqual() to compare handles #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkordenbrock
force-pushed
the
topic/main/portals4-use-PtlHandleIsEqual
branch
from
6c0a2d1
to
cefee2e
Compare
|
@tkordenbrock Curious are you planning to backport this to v5.0.x? |
Yes, this one will be backported to v5.0.x. |
The Portals4 standard requires the use of PtlHandleIsEqual() instead of the (in)equality operatror, because a handle may be a compound data type that cannot be directly compared. Signed-off-by: Todd Kordenbrock <[email protected]>
tkordenbrock
force-pushed
the
topic/main/portals4-use-PtlHandleIsEqual
branch
from
cefee2e
to
1d891d3
Compare
mdosanjh
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Portals4 standard requires the use of PtlHandleIsEqual() instead of the (in)equality operatror, because a handle may be a compound data type that cannot be directly compared.
Thanks to @nbartelheimer for the bug report.