sessions: fix some problems with multiple init/fini #12868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a couple of problems uncovered in issue open-mpi#12854. Turns out the MCA param management system was "remembering" things even if a variable was deregistered when a framework was closed. Also the test case showed that destructing ompi_mpi_session_null needs to be moved to ompi_mpi_instance_release. Related to open-mpi#12854 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
requested review from
jsquyres and
edgargabriel
and removed request for
jsquyres
edgargabriel
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of problems uncovered in issue #12854.
Turns out the MCA param management system was "remembering" things even if a variable was deregistered when a framework was closed.
Also the test case showed that destructing ompi_mpi_session_null needs to be moved to ompi_mpi_instance_release.
Related to #12854