Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode FORS indices similarly to WOTS #1839

Closed

Conversation

GillonB
Copy link

@GillonB GillonB commented Jul 10, 2024

Update the decoding of the FORS indices as proposed by latest NIST changes. This has already been proposed in the sphincsplus repo (sphincs/sphincsplus#51). Would be good to have the same for liboqs as this change will eventually land. https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/88tuvtb7nN4/m/DA1QCoJWBAAJ

  • This changes breaks SPHINCS+ signature compatibility: Signatures generated before cannot be verified correctly with the implementation after this change. Also old implementation cannot verify correctly newly generate signatures.
  • No change to available algorithms

relates to #1838

@GillonB GillonB requested a review from dstebila as a code owner July 10, 2024 10:10
@GillonB GillonB marked this pull request as draft July 10, 2024 10:24
@dstebila
Copy link
Member

Because we're pulling out SPHINCS+ implementation from PQClean, we'd prefer to see this change made first in PQClean, and then our automated scripts can pull it in. Would you be able to do that?

@SWilson4
Copy link
Member

Closing due to inactivity. Additionally, rather than updating the SPHINCS+ code in place, we will presumably be replacing it with the final version of SLH-DSA whenever it lands upstream.

@SWilson4 SWilson4 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants