Switch bit.dev dependency install system #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AndrewLester
changed the title
|
@braddf this all good? |
|
@peterdudfield - that's a good question... @AndrewLester, has this gone in already into another branch, and/or did you do it differently in the end..? |
|
@braddf, so this code hasn't gone into another branch in any way, but the code here is the most recent version that I've sent up to the bit cloud with all the components. Additionally, I removed all components stored in bit cloud from this repo to reduce clutter, and they can be added back if necessary (to edit them). Merging this PR won't affect what's in bit cloud (since it's already there), it will just, hopefully, reduce clutter in the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
In this PR I've migrated to using yarn to incorporate bit dependencies. Tailwind with bit just doesn't seem to work on tailwindcss 3, so we'll be using it mostly for config sharing and icon/logo sharing (we're already using it, this just keeps this repo up to date with what's on the bit cloud, note the version bumps for components.).
I also removed the source for the bit component that was still in the repo (layout header). I'm not sure the best practice here, but I think just leaving the source on bit cloud for now won't be much of a problem since there won't be frequent changes to the icons and logo.
To update any of the components, one can just bit import them and push new snapped changes.
I can also replace instances of the source components in this repo to use the bit versions (remove source from this repo and install from bit.dev), like this one for example:
https://github.com/openclimatefix/nowcasting/blob/80e7511aeea799cc4103e93ee84a198acc9e0947/apps/nowcasting-app/components/icons/icons.tsx#L16
Also: it's been a while since I've looked into the monorepo setup, so my additions to the root
yarn.lockmight be unnecessary. Let me know and I can revert that.How Has This Been Tested?
Currently these bit dependencies are available on the bit cloud, and installed in
pv-sites-mobile.Checklist: