Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/ci #464

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Issue/ci #464

merged 6 commits into from
Feb 5, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 5, 2024

Pull Request

Description

Add yarn test to CI

Fixes #462

How Has This Been Tested?

Github action works

  • Yes

Didnt do codecov for the moment, as it didnt seem to work, left this in #465

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 0:42am

Copy link
Contributor

@rachel-labri-tipton rachel-labri-tipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @peterdudfield, this looks good! I wasn't sure that yarn test --coverage ran all the tests, but I just checked on the new-cypress-testing branch and it does run all the test suites: cypress + jest.

@peterdudfield peterdudfield merged commit d73b941 into development Feb 5, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/ci branch February 5, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests in CI
2 participants