Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merge paused for India MVP] New cypress testing #470

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Feb 14, 2024

Pull Request

Description

Add Cypress test suite to run on CI and commit
Fixes #454

How Has This Been Tested?

In local and CI

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview Feb 14, 2024 0:13am

Copy link
Contributor

@rachel-labri-tipton rachel-labri-tipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good @braddf. We'll add the other tests bit by bit.

@rachel-labri-tipton
Copy link
Contributor

hey @braddf, just wanted to double check that it's ok this is getting merged into main and not development. I probably should have asked this yesterday.

@braddf braddf changed the base branch from main to development February 15, 2024 09:21
@braddf
Copy link
Contributor Author

braddf commented Feb 15, 2024

@rachel-labri-tipton thanks for the review and nope you're absolutely right, should be into development I'd just missed that – have amended now!

@braddf braddf changed the title New cypress testing [merge paused for India MVP] New cypress testing Feb 15, 2024
@rachel-labri-tipton rachel-labri-tipton merged commit 9a47351 into development Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta issue] FE E2E Testing
2 participants