Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten 3.1.65 fix #8067

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

Jonathhhan
Copy link
Contributor

@Jonathhhan Jonathhhan commented Aug 1, 2024

Not sure, if this is backward compatible, but it works wit the current Emscripten version.
Also, the apothecary libs need to be rebuild with the current Emscripten version.

@danoli3
Copy link
Member

danoli3 commented Aug 2, 2024

You were able to build and test in browser this working ?

@Jonathhhan
Copy link
Contributor Author

Jonathhhan commented Aug 2, 2024

@danoli3 actually I need to test it a little more. A lot of errors are resolved, but there is an issue with emrun. Similar to this one: emscripten-core/emscripten#14128 which was not there before. But it should work, if uploaded to a webserver (did not test that, yet).

Here a related thread (was the starting point for this PR): https://forum.openframeworks.cc/t/compiling-errors-of-ofxemscripten-when-making-3dprimitives-example/43731

@danoli3
Copy link
Member

danoli3 commented Aug 2, 2024

Please test, I might also, as I've been chasing my tail to find the right settings to work in Site.

I was crashing on getGLError before that using just updated EM_BOOL stuff as above, but ended up finding a MAIN function in the old freeimage library on the old version so thats now fixed
#8056

Anyways I believe the old binding ways maybe causing something to break bad. I opted to just port us to GLFW and have working code to fix up but multi-window stuff was really, exciting

I'm happy to merge this first on old libs if it's working as is with, as EM_SDK it kinda forces latest in most example scripts to download it or run it.

I also was looking at your other PR's with the audio stuff, lets get those in once isolate issues with workers, might be a good idea to just create template project makes for each unique feature like that, as it does become a core change requirement... however we could define somewhere, not exactly sure how the config.emscripten.default.mk

@danoli3 danoli3 self-assigned this Aug 2, 2024
@danoli3
Copy link
Member

danoli3 commented Aug 12, 2024

@Jonathhhan how did you go any working test? I might checkout your PR and see myself

@Jonathhhan
Copy link
Contributor Author

Jonathhhan commented Aug 13, 2024

I am sorry. I am away from my computer for a good week now, and did not manage to test it before. Will definitely come back to this. Until then it is still possible to use older Emscripten versions...

@danoli3 danoli3 merged commit b7c5147 into openframeworks:master Aug 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants