Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix https://github.com/openimsdk/open-im-server/issues/2895 #2896

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix https://github.com/openimsdk/open-im-server/issues/2895 #2896

wants to merge 4 commits into from

Conversation

morya
Copy link
Contributor

@morya morya commented Nov 26, 2024

🅰 Please add the issue ID after "Fixes #"

Fixes #2895

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@skiffer-git
Copy link
Member

[2024-11-26 09:10:25 UTC] Some programs are not running properly:
binary openim-msggateway is not running as expected: /home/runner/work/open-im-server/open-im-server/_output/bin/platforms/linux/amd64/openim-msggateway expected 1 processes, but 0 running

@morya
Copy link
Contributor Author

morya commented Nov 28, 2024

[2024-11-26 09:10:25 UTC] Some programs are not running properly: binary openim-msggateway is not running as expected: /home/runner/work/open-im-server/open-im-server/_output/bin/platforms/linux/amd64/openim-msggateway expected 1 processes, but 0 running

when there are no rpc.ports config inside './config/openim-msggateway.yml' , code will fail to run due to index error.

last commit fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] no need to specify port and ports in config for RPC services
2 participants
@morya @skiffer-git