-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code model attribute #282
base: code-reflection
Are you sure you want to change the base?
Code model attribute #282
Conversation
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
This is experimental serialization of code model into a custom method attribute.
I've performed brief comparison on
BytecodeTest
as a representant of class with majority of methods annotated with@CodeReflection
.Compiled size of the
BytecodeTest
class (with text-encoded code models) is 121288 bytes, CP contains 1612 entries.Cleaned size of the class (removed text-encoded code models and their static initialization) is 32801 bytes, CP contains 1277 entries.
Size with models encoded in custom attributes is 74541 bytes, CP contains 1435 entries.
Proportional size of the custom attributes vs. text-encoded fields is 37% (47% of the CP entries).
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/282/head:pull/282
$ git checkout pull/282
Update a local copy of the PR:
$ git checkout pull/282
$ git pull https://git.openjdk.org/babylon.git pull/282/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 282
View PR using the GUI difftool:
$ git pr show -t 282
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/282.diff
Using Webrev
Link to Webrev Comment