Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate HIP backend to bldr infrastructure. #296

Open
wants to merge 1 commit into
base: code-reflection
Choose a base branch
from

Conversation

iotamudelta
Copy link
Contributor

@iotamudelta iotamudelta commented Dec 12, 2024

jextract fails in the presence of HIP on OpenCL/OpenGL - disable those for now if HIP is present.

While there, catch up to the reflection include change.


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/296/head:pull/296
$ git checkout pull/296

Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.org/babylon.git pull/296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 296

View PR using the GUI difftool:
$ git pr show -t 296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/296.diff

Using Webrev

Link to Webrev Comment

jextract fails in the presence of HIP on OpenCL/OpenGL - disable those
for now if HIP is present.

While there, catch up to the reflection include change.
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back iotamudelta! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@iotamudelta This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Integrate HIP backend to bldr infrastructure.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant