8346178: [CRaC] Failure in com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java #161
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test takes all dcmd commands and invokes each to check if a command exceeds permissions set up in the test.
This fix simply excludes
jdk.checkpoint
command from the test and keeps the rest of the test logic untouched. This approach was chosen because (1) checkpointing requires many permissions and it would be better to create a separate test for this if we want to "document" these permissions since the current test does not separate permission sets by commands, (2) the test would need additional adjustments to actually perform a checkpoint due to the CRaC specifics.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/161/head:pull/161
$ git checkout pull/161
Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/crac.git pull/161/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 161
View PR using the GUI difftool:
$ git pr show -t 161
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/161.diff
Using Webrev
Link to Webrev Comment