Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287596: Reorg jdk.test.lib.util.ForceGC #2640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Mar 29, 2024

Hello
I'd like to backport this enhancement to fix regression in java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java caused by JDK-8300727. The backport of JDK-8300727 requires JDK-8287596 to be applied first.

The main differences from the JDK17 patch are the following:

  • Reference::refersTo() is introduced in JDK16. Reference::get is used instead
  • test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java in JDK11 does not use ForceGC. Skipped
  • no test/jdk/java/lang/invoke/defineHiddenClass/UnloadingTest.java in JDK11
  • This patch also includes JDK-8261851 changes as part of the test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java patch

All related jtreg tests passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8287596 needs maintainer approval

Error

 ⚠️ 8287596 is used in problem lists: [test/jdk/ProblemList.txt]

Issue

  • JDK-8287596: Reorg jdk.test.lib.util.ForceGC (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2640/head:pull/2640
$ git checkout pull/2640

Update a local copy of the PR:
$ git checkout pull/2640
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2640

View PR using the GUI difftool:
$ git pr show -t 2640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2640.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 82a8bd7e92a1867b0c82f051361938be8610428d 8287596: Reorg jdk.test.lib.util.ForceGC Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 29, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2024

@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 25, 2024
@alexeybakhtin
Copy link
Contributor Author

alexeybakhtin commented Sep 25, 2024

/open

@alexeybakhtin
Copy link
Contributor Author

alexeybakhtin commented Sep 25, 2024

MR is reopened to fix JTREG failure

@openjdk openjdk bot reopened this Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@alexeybakhtin This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

3 similar comments
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant