-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301118: Ignore allow and disallow options for java.security.manager System Property #2932
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Kindly reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change lgtm, would be good to check Oracle 11u to see whether it issues a warning.
The OSX build failures appear unrelated but should be addressed in a different PR.
|
@phohensee Thanks for the review! |
/approval request Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). The change isn't a backport change and implemented according to the description of the issue. New allow/disallow options for the java.security.manager system property should be ignored in JDK11. |
@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Proposing the change for parity with Oracle (fixed in 11.0.21-oracle).
The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11.
New test fails without the change and passes with the change.
Progress
Issues
Backport <hash>
with the hash of the original commit. See Backports.Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2932/head:pull/2932
$ git checkout pull/2932
Update a local copy of the PR:
$ git checkout pull/2932
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2932/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2932
View PR using the GUI difftool:
$ git pr show -t 2932
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2932.diff
Using Webrev
Link to Webrev Comment