Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301118: Ignore allow and disallow options for java.security.manager System Property #2932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented Sep 6, 2024

Proposing the change for parity with Oracle (fixed in 11.0.21-oracle).

The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11.

New test fails without the change and passes with the change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8301118 needs maintainer approval
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8301251 to be approved

Issues

  • JDK-8301118: Ignore allow and disallow options for java.security.manager System Property (Enhancement - P3 - Requested) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • JDK-8301251: Ignore allow and disallow options for java.security.manager System Property (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2932/head:pull/2932
$ git checkout pull/2932

Update a local copy of the PR:
$ git checkout pull/2932
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2932

View PR using the GUI difftool:
$ git pr show -t 2932

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2932.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2024

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@dimitryc
Copy link
Contributor Author

dimitryc commented Nov 1, 2024

Kindly reminder

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm, would be good to check Oracle 11u to see whether it issues a warning.

The OSX build failures appear unrelated but should be addressed in a different PR.

@openjdk
Copy link

openjdk bot commented Nov 4, 2024

⚠️ @dimitryc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@dimitryc
Copy link
Contributor Author

dimitryc commented Nov 5, 2024

@phohensee Thanks for the review!

@dimitryc
Copy link
Contributor Author

dimitryc commented Nov 5, 2024

/approval request Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). The change isn't a backport change and implemented according to the description of the issue. New allow/disallow options for the java.security.manager system property should be ignored in JDK11.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@dimitryc
8301118: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 5, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants