-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313374: --enable-ccache's CCACHE_BASEDIR breaks builds #2960
base: master
Are you sure you want to change the base?
8313374: --enable-ccache's CCACHE_BASEDIR breaks builds #2960
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22. |
@sendaoYan |
Hi all,
This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.
The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.
Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2960/head:pull/2960
$ git checkout pull/2960
Update a local copy of the PR:
$ git checkout pull/2960
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2960/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2960
View PR using the GUI difftool:
$ git pr show -t 2960
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2960.diff
Using Webrev
Link to Webrev Comment