Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? #2963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 10, 2024

Hi all,
This is clean backport of JDK-8231058, to fix JVM crash when running with -XX:+VerifyOops. The newly added test run failed before this backport, and run passed after apply this backport.

Additonal testing:

  • linux aarch64 build with release/slowdebug configure
  • linux x86_64 build with release/slowdebug configure
  • jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64
  • jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8231058 needs maintainer approval

Issue

  • JDK-8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2963/head:pull/2963
$ git checkout pull/2963

Update a local copy of the PR:
$ git checkout pull/2963
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2963

View PR using the GUI difftool:
$ git pr show -t 2963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2963.diff

Using Webrev

Link to Webrev Comment

…for non comment?

Offset method should only be called for comments.

Reviewed-by: roland, dholmes
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6bc9833f65aefaaba189d4d26091261d2d9ca8b0 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? Nov 10, 2024
@openjdk
Copy link

openjdk bot commented Nov 10, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 10, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8231058, to fix JVM crash when running with -XX:+VerifyOops. The newly added test run failed before this backport, and run passed after apply this backport. The change has been verified with jtreg(include tier1/2/3 etc.) on linux-x64 and linux-aarch64.

@openjdk
Copy link

openjdk bot commented Nov 10, 2024

@sendaoYan
8231058: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 10, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8231058, to fix JVM crash when running with -XX:+VerifyOops. The newly added test run failed before this backport, and run passed after apply this backport. The change has been verified with jtreg(include tier1/2/3 etc.) on linux-x64 and linux-aarch64.

@openjdk
Copy link

openjdk bot commented Dec 8, 2024

@sendaoYan
8231058: The approval request was already up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants