8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1

[vieiro]

An implementation of JDK-8343786 that bumps the GHA runners versions to macos-13 and XCode 14.3.1.

This uses the --enable-xcode14 configuration flag introduced in #2966 (JDK-8344458) to build and run tier-1 tests on macos-13 and XCode 14.3.1.

Tier-1 tests seem to be failing randomly on macos-13/XCode14 with either a timeout or an ArrayIndexOutOfBoundsException t in serviceability/sa/ClhsdbFindPC.java. This is currently under investigation and may be related to JDK-8260389 or JDK-8277079.

The rest of tier1 tests are expected to pass on this platform.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8343786 needs maintainer approval

Issue

• JDK-8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1 (Enhancement - P4 - Requested)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2967/head:pull/2967
$ git checkout pull/2967

Update a local copy of the PR:
$ git checkout pull/2967
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2967

View PR using the GUI difftool:
$ git pr show -t 2967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2967.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/2966 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 04: Full (1274d5e9)
• 03: Full - Incremental (fcfdd708)
• 02: Full (34a5b048)
• 01: Full - Incremental (32101230)
• 00: Full (32101230)

[openjdk]

@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[vieiro]

As expected, all tier1 tests pass with XCode 14 but for ClhsdbFindPC, that fails with a timeout. Suspect is JDK-8260389 that will require investigation (intermittent).

2024-11-19T08:29:29.3416570Z java.lang.RuntimeException: Test ERROR java.io.IOException: App waiting timeout
2024-11-19T08:29:29.3418220Z 	at ClhsdbFindPC.testFindPC(ClhsdbFindPC.java:155)

Attaching excerpt of the build log for future reference:
xcode14-build-failure.txt

[vieiro]

The second commit replaces the original --enable-xcode14 with --disable-warnings-as-errors.

Again, build and tests are expected to pass but for an ArrayIndexOutOfBoundsException in `serviceability/sa/ClhsdbFindPC.java'

[gnu-andrew]

Can we update this PR so it targets master rather than 2966? Then we can integrate this and look into turning the warnings-as-errors back on long term.

[openjdk]

@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[vieiro]

Rebased on master.

[gnu-andrew]

Thanks. Assuming this builds as before, we can integrate.

[gnu-andrew]

This looks ok to go in, but I don't know if you want to hold off for now to allow testing of #2966 with MacOS 12.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[vieiro]

This looks ok to go in, but I don't know if you want to hold off for now to allow testing of #2966 with MacOS 12.

I think this change with --disable-warnings-as-errors supersedes #2966 , so let's close #2966 and let's get this in.

Next efforts should go to fix the Clhsdb test failure (adding log for the record).

clhsdb-failure.txt

[vieiro]

/approval request Bump 11u GHA to macos-13/ XCode 14.3.1 since macos-12/XCode 13.4.1 is going to be deprecated

[openjdk]

@vieiro
8343786: The approval request has been created successfully.

[jerboaa]

Next efforts should go to fix the Clhsdb test failure (adding log for the record).

Agreed. Looks like a backport of https://bugs.openjdk.org/browse/JDK-8243455 would fix it (test only change).

[vieiro]

Agreed. Looks like a backport of https://bugs.openjdk.org/browse/JDK-8243455 would fix it (test only change).

Yep, but that's far away from the current state in 11 (8244670, 8273928, 8264775, 8243455, 8261929, 8261098, 8247514 and/or 8260296) may need to be applied first.

Also it seems this is in ProblemList.txt because of (8294316 and 8267433).

I'll try to investigate during the next weeks.

[vieiro]

After some investigation it seems that the ArrayIndexOutOfBoundsException is just a consequence of a previous error:

2024-11-27T16:35:06.3750870Z Opening core file, please wait...
2024-11-27T16:35:06.3751320Z ERROR: failed to workaround classshareing
2024-11-27T16:35:06.3751780Z Unable to open core file

I applied JDK-8294316 "SA core file support is broken on macosx-x64 starting with macOS 12.x" in this fork and the core files are now properly parsed and the test passes without problems.

I'll try to backport JDK-8294316 to upper OpenJDK versions and get it into 11.