Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ #2969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkia
Copy link

@wkia wkia commented Nov 22, 2024

Clean backport to 11u.
This fixes "make test" build problem occured with make version <4.0 in JDK11.
The new test is passed locally with a manual run with both "GNU Make 3.82" and "GNU Make 4.3".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301753 needs maintainer approval

Issue

  • JDK-8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2969/head:pull/2969
$ git checkout pull/2969

Update a local copy of the PR:
$ git checkout pull/2969
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2969

View PR using the GUI difftool:
$ git pr show -t 2969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2969.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a39cf2e3b242298fbf5fafdb8aa9b5d4562061ef 8301753: AppendFile/WriteFile has differences between make 3.81 and 4+ Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

@wkia
Copy link
Author

wkia commented Nov 22, 2024

/approval 8301753 request Clean backport to 11u. This fixes "make run-test-prebuilt" build problem occured with make version <4.0 in JDK11.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@wkia
8301753: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant