Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit #2426

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 24, 2024

WIP.

The backport is not clean because:

  1. The hunk in macro.cpp does not apply to JDK 21, because it was added later with JDK-8287061
  2. The @Arguments style in IR test does not work in JDK 21, because the API was added later with JDK-8324641
  3. The definitions for Membar nodes for IR tests were in different format.

Additional testing:

  • New benchmark improves
  • New IR test passes with the fix, fails without it
  • Linux AArch64 server fastdebug, all
  • Linux x86_64 server fastdebug, all
  • Linux AArch64 server fastdebug, Maven CTW and Fuzzer tests
  • Linux x86_64 server fastdebug, Maven CTW and Fuzzer tests

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8300148 needs maintainer approval

Issue

  • JDK-8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2426/head:pull/2426
$ git checkout pull/2426

Update a local copy of the PR:
$ git checkout pull/2426
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2426

View PR using the GUI difftool:
$ git pr show -t 2426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2426.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1d06170758bd76a0ea32e5bb7d4a017e829ae710 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 24, 2024
@shipilev shipilev force-pushed the JDK-8300148-c2-storestore branch 2 times, most recently from 038ff09 to 7f01da4 Compare April 25, 2024 07:10
@shipilev shipilev force-pushed the JDK-8300148-c2-storestore branch from 7f01da4 to e6f37c5 Compare April 25, 2024 07:43
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

Not now, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

Not now, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

3 similar comments
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@shipilev This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant