8284093: Memory leak: X11SD_DisposeXImage should also free obdata

[mrserb]

Hi all,

This pull request contains a backport of commit 205cfb84 from the openjdk/jdk repository.

The commit being backported was authored by Zhengyu Gu on 11 Apr 2022 and was reviewed by Phil Race and Andrew John Hughes.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8284093 needs maintainer approval

Issue

• JDK-8284093: Memory leak: X11SD_DisposeXImage should also free obdata (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2616/head:pull/2616
$ git checkout pull/2616

Update a local copy of the PR:
$ git checkout pull/2616
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2616

View PR using the GUI difftool:
$ git pr show -t 2616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2616.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[fitzsim]

I am not a Reviewer; I maintain java-17-openjdk in RHEL so I try to review jdk17u-dev pull requests, time-permitting.

@mrserb can you try re-running the failed GitHub Actions checks? The linux-x64-hs-nopch one at least represents an intermittent failure mode of GHA that I have seen before; it should pass when re-run.

This looks like a good fix to have in 17; do you plan to request maintainer approval at some point?