-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 #2979
base: master
Are you sure you want to change the base?
8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 #2979
Conversation
Hi @Sorna-Sarathi, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Sorna-Sarathi" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
Here also, GHA is not enabled. |
@Sorna-Sarathi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request fixes failure when creating non-CRT RSA private keys in SunPKCS11. Backporting it. |
@Sorna-Sarathi |
Hi all,
This pull request contains a backport of commit 3251eea from the openjdk/jdk repository.
I've also resolved a build failure with the latest version of gtest(In JDK17) by backporting the fix.
Thanks!
JBS Issue: JDK-8336499
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2979/head:pull/2979
$ git checkout pull/2979
Update a local copy of the PR:
$ git checkout pull/2979
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2979/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2979
View PR using the GUI difftool:
$ git pr show -t 2979
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2979.diff
Using Webrev
Link to Webrev Comment