Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport jdk 8341779 #3038

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Nov 11, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3038/head:pull/3038
$ git checkout pull/3038

Update a local copy of the PR:
$ git checkout pull/3038
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3038

View PR using the GUI difftool:
$ git pr show -t 3038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3038.diff

@cushon cushon marked this pull request as draft November 11, 2024 18:40
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2024

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@fitzsim
Copy link
Contributor

fitzsim commented Nov 12, 2024

Thank you for providing this draft. I replicated the crash in my environment, confirmed the lines added to the test are required to trigger the crash, and confirmed that reverting "Disable handling of annotations with different retention at the same location" fixes the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants