Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information #3057

Open
wants to merge 1 commit into
base: pr/3056
Choose a base branch
from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Nov 18, 2024

Follow-up clean test backport for JDK-8179502 (third in the series, applied after 8310629)


Progress

  • Change must not contain extraneous whitespace
  • JDK-8325024 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #3056 must be integrated first

Issue

  • JDK-8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information (Bug - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3057/head:pull/3057
$ git checkout pull/3057

Update a local copy of the PR:
$ git checkout pull/3057
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3057

View PR using the GUI difftool:
$ git pr show -t 3057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3057.diff

Using Webrev

Link to Webrev Comment

…ncorrect comment information

Reviewed-by: jnimeh, fyang
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/3056 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 432756b6e51c903e2bff8b9c3028a4f2ea8973f4 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@openjdk openjdk bot added the approval label Nov 18, 2024
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant