8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:

[GoeLin]

I backport this to improve testing on win.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314909 needs maintainer approval

Issue

• JDK-8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]: (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3110/head:pull/3110
$ git checkout pull/3110

Update a local copy of the PR:
$ git checkout pull/3110
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3110

View PR using the GUI difftool:
$ git pr show -t 3110

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3110.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• ff496b9: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (fadb5f47)

[fitzsim]

Typos in the comment: platfrom == windowws => platform == windows.

[GoeLin]

GHA failure: gc/metaspace/TestMetaspacePerfCounters.java#Shenandoah-64 fails.
We have seen this failing in the tests before. It used to be quite prominent, lately it's rare. Unrelated to this change.

[GoeLin]

Typos in the comment: platfrom == windowws => platform == windows.

Hi @fitzsim, good catch! But this is a backport, so not the right place to fix this. If you want to follow up with this you can file a bug against jdk.