Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345296: AArch64: VM crashes with SIGILL when prctl is disallowed #3111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krk
Copy link
Contributor

@krk krk commented Dec 12, 2024

Ref. openjdk/jdk#22479

We have caught this in some prod environments, where prctl is forbidden by the sandboxing mechanism. This fails the JVM

Does not apply cleanly, the backport depends on FloatRegister changes from JDK-8339063 which are included in src/hotspot/cpu/aarch64/register_aarch64.hpp.

Additional testing:

  • Verified the bug is fixed with the seccomp repro from JDK-8345296: Segfault without the patch, works with.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345296 needs maintainer approval

Issue

  • JDK-8345296: AArch64: VM crashes with SIGILL when prctl is disallowed (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3111/head:pull/3111
$ git checkout pull/3111

Update a local copy of the PR:
$ git checkout pull/3111
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3111

View PR using the GUI difftool:
$ git pr show -t 3111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3111.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3c60f0b2bb75150d49da9ab94d88b767275de5e2 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, thanks.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

⚠️ @krk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@krk
Copy link
Contributor Author

krk commented Dec 12, 2024

/approval request Fix VM crash on production workloads when prctl is disallowed, on AArch64 with SVE.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@krk
8345296: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants