Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk18 Public archive

8278851: Correct signer logic for jars signed with multiple digestalgs #32

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coffeys
Copy link

@coffeys coffeys commented Dec 15, 2021

The manifest entry verifier exits too quickly in the case where multiple digests are used in a JarEntry and weak digests are present.

I've introduced some test test library functionality to help with jar signing. I've retrofitted one of my earlier tests with that new functionality also in this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278851: Correct signer logic for jars signed with multiple digestalgs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.java.net/jdk18 pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/32.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2021

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2021

@coffeys The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@coffeys coffeys changed the title 8278851: Correct signer logic for jars signed with multiple weak digestalgs 8278851: Correct signer logic for jars signed with multiple digestalgs Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

1 participant