Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346069: Add missing Classpath exception statements #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sorna-Sarathi
Copy link

@Sorna-Sarathi Sorna-Sarathi commented Dec 13, 2024

Hi,
This PR contains backport of openjdk/jdk#22704.
Backport CPE statements.

JDK Issue: JDK-8346069


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346069 needs maintainer approval

Issue

  • JDK-8346069: Add missing Classpath exception statements (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk24u.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/3.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back Sorna-Sarathi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 09c29d1d4274d9c36e1af98f02e6fc5b3f35133f 8346069: Add missing Classpath exception statements Dec 13, 2024
@openjdk
Copy link

openjdk bot commented Dec 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

⚠️ @Sorna-Sarathi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

@Sorna-Sarathi
Copy link
Author

/approval request adds missing classpath exception statements in several files. Backporting it.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@Sorna-Sarathi
8346069: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 13, 2024
@kevinrushforth
Copy link
Member

@Sorna-Sarathi This repo is for JDK 24 Updates, starting with 24.0.1. This bug fix is a good candidate for JDK 24 itself. I recommend that you close this PR and instead open a backport PR to the jdk:jdk24 stabilization branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants