Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6586559: Support for vertex colors #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kneesnap
Copy link

@Kneesnap Kneesnap commented Sep 6, 2024

Implements vertex color support for TriangleMesh.
Demonstrates a possible implementation of this feature proposal.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-6586559: Support for vertex colors (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1557/head:pull/1557
$ git checkout pull/1557

Update a local copy of the PR:
$ git checkout pull/1557
$ git pull https://git.openjdk.org/jfx.git pull/1557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1557

View PR using the GUI difftool:
$ git pr show -t 1557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1557.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 6, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2024

Hi @Kneesnap, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Kneesnap" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@Kneesnap
Copy link
Author

Kneesnap commented Sep 6, 2024

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 6, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2024

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Sep 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@Kneesnap Kneesnap changed the title WIP: Add vertex color support to TriangleMesh 6586559: Add vertex color support to TriangleMesh Sep 10, 2024
@Kneesnap Kneesnap marked this pull request as ready for review September 10, 2024 02:11
@Kneesnap
Copy link
Author

Dear reviewers, an application available for manual testing is available by running
C:\Program Files\Java\jdk-21\bin\java" -cp "{PATH TO JFX REPOSITORY}\apps\toys\FX8-3DFeatures\dist\FX8-3DFeatures.jar" --module-path "{PATH TO JFX REPOSITORY}\build\sdk\lib" --add-modules=javafx.controls,javafx.graphics fx83dfeatures.DynamicMeshViewer (You can run in any other way too)

@Kneesnap Kneesnap changed the title 6586559: Add vertex color support to TriangleMesh 6586559: Support for vertex colors Sep 10, 2024
@Kneesnap Kneesnap changed the title 6586559: Support for vertex colors 6586559: Support for vertex colors (Enhancement - P5) Sep 10, 2024
@Kneesnap Kneesnap changed the title 6586559: Support for vertex colors (Enhancement - P5) 6586559: Support for vertex colors (Enhancement - P5) Sep 10, 2024
@Kneesnap Kneesnap changed the title 6586559: Support for vertex colors (Enhancement - P5) 6586559: Support for vertex colors Sep 10, 2024
@robilad
Copy link

robilad commented Sep 18, 2024

hi, please send me an e-mail at [email protected] so that I can verify your account.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Kneesnap
Copy link
Author

Kneesnap commented Oct 17, 2024 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Kneesnap
Copy link
Author

Kneesnap commented Nov 14, 2024 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Kneesnap
Copy link
Author

Kneesnap commented Dec 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants