Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed #1650

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 27, 2024

Add the --sun-misc-unsafe-memory-access=allow flag until JDK-8334137 is fixed to avoid warnings when running tests (automated and manual) with JDK 24.

I've tested this using a boot JDK of JDK 22.0.2, JDK 23 (the boot JDK we use in production), and in our CI with the latest promoted build of JDK 24, which now warns by default when a deprecated method in sun.misc.Unsafe is called.

Without this fix, we see a warning when running our automated or manual tests with JDK 24. With this fix, we see no warnings.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1650/head:pull/1650
$ git checkout pull/1650

Update a local copy of the PR:
$ git checkout pull/1650
$ git pull https://git.openjdk.org/jfx.git pull/1650/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1650

View PR using the GUI difftool:
$ git pr show -t 1650

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1650.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

build.gradle Outdated
Comment on lines 770 to 771
ext.jdk23OrLater = jdkVersionInfo.feature() >= 23
ext.jdk24OrLater = jdkVersionInfo.feature() >= 24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really only need to add --sun-misc-unsafe-memory-access=allow when running with JDK 24 or later ("allow" is the default in JDK 23). I want to do initial testing on JDK 23 with this flag, but will likely change all of the checks to jdk24OrLater for the final version, in which case we won't need the jdk23OrLater flag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the above change.

@kevinrushforth kevinrushforth marked this pull request as ready for review December 13, 2024 16:17
@openjdk openjdk bot added the rfr Ready for review label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant