8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed #1650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--sun-misc-unsafe-memory-access=allow
flag until JDK-8334137 is fixed to avoid warnings when running tests (automated and manual) with JDK 24.I've tested this using a boot JDK of JDK 22.0.2, JDK 23 (the boot JDK we use in production), and in our CI with the latest promoted build of JDK 24, which now warns by default when a deprecated method in
sun.misc.Unsafe
is called.Without this fix, we see a warning when running our automated or manual tests with JDK 24. With this fix, we see no warnings.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1650/head:pull/1650
$ git checkout pull/1650
Update a local copy of the PR:
$ git checkout pull/1650
$ git pull https://git.openjdk.org/jfx.git pull/1650/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1650
View PR using the GUI difftool:
$ git pr show -t 1650
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1650.diff
Using Webrev
Link to Webrev Comment