-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345188: Support tree-structural pseudo-classes #1652
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request. @mstr2 please create a CSR request for issue JDK-8345188 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
Webrevs
|
This will require a change to Additionally, changes will likely be needed to the two places where we say that JavaFX doesn't support structural pseudo-classes, here and here, since |
I've expanded the scope of this enhancement to also include several child-indexed pseudo-classes, which are also structural pseudo-classes. I specifically didn't include the |
The CSS Selectors specification defines the
:root
pseudo-class that matches root nodes:https://www.w3.org/TR/selectors-4/#the-root-pseudo
JavaFX uses the non-standard
.root
style class for the same purpose. We should also support the:root
pseudo-class for increased compatibility of JavaFX CSS with the web specification.Additionally, we should also support the following child-indexed pseudo-classes:
:first-child
:last-child
:only-child
:nth-child()
with argumentseven
andodd
The
An+B [of S]?
microsyntax for:nth-child()
is not supported, as this would require major changes in JavaFX CSS./reviewers 2
/csr
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1652/head:pull/1652
$ git checkout pull/1652
Update a local copy of the PR:
$ git checkout pull/1652
$ git pull https://git.openjdk.org/jfx.git pull/1652/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1652
View PR using the GUI difftool:
$ git pr show -t 1652
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1652.diff
Using Webrev
Link to Webrev Comment