Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null handling in updateUndoRedoState method #1657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheCiosiek
Copy link

@TheCiosiek TheCiosiek commented Dec 6, 2024

The updateUndoRedoState method now properly handles cases where undoChange is null, preventing null pointer exceptions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1657/head:pull/1657
$ git checkout pull/1657

Update a local copy of the PR:
$ git checkout pull/1657
$ git pull https://git.openjdk.org/jfx.git pull/1657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1657

View PR using the GUI difftool:
$ git pr show -t 1657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1657.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 6, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2024

Hi @TheCiosiek, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user TheCiosiek" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

⚠️ @TheCiosiek a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master a431801c3d1d76f03c54f7f3451eac4fa8024e8b
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant