8345136: Update JDK_DOCS property to point to JDK 23 docs #1663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs bundle to point to the JDK 23 docs (we're currently pointing to JDK 21).
I will need to also download and host a zip bundle and add its checksum to gradle/verification-metadata.xml to avoid breaking our internal CI build.
As mentioned in JDK-8325873 when we updated the docs to use JDK 21, we should do this as a part of updating the boot JDK. To facilitate this, and to move more version number properties to a common place, I will create a new
jdk.docs.version
property inbuild.properties
and put it near thejfx.build.jdk.version
property.Both the GHA build and our CI build are successful.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1663/head:pull/1663
$ git checkout pull/1663
Update a local copy of the PR:
$ git checkout pull/1663
$ git pull https://git.openjdk.org/jfx.git pull/1663/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1663
View PR using the GUI difftool:
$ git pr show -t 1663
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1663.diff
Using Webrev
Link to Webrev Comment