Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345136: Update JDK_DOCS property to point to JDK 23 docs #1663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 13, 2024

Update the docs bundle to point to the JDK 23 docs (we're currently pointing to JDK 21).

I will need to also download and host a zip bundle and add its checksum to gradle/verification-metadata.xml to avoid breaking our internal CI build.

As mentioned in JDK-8325873 when we updated the docs to use JDK 21, we should do this as a part of updating the boot JDK. To facilitate this, and to move more version number properties to a common place, I will create a new jdk.docs.version property in build.properties and put it near the jfx.build.jdk.version property.

Both the GHA build and our CI build are successful.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8345136: Update JDK_DOCS property to point to JDK 23 docs (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1663/head:pull/1663
$ git checkout pull/1663

Update a local copy of the PR:
$ git checkout pull/1663
$ git pull https://git.openjdk.org/jfx.git pull/1663/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1663

View PR using the GUI difftool:
$ git pr show -t 1663

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1663.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@kevinrushforth kevinrushforth marked this pull request as ready for review December 13, 2024 14:35
@openjdk openjdk bot added the rfr Ready for review label Dec 13, 2024
@kevinrushforth
Copy link
Member Author

Reviewers: @arapte or @andy-goryachev-oracle AND @tiainen or @johanvos

/reviewers 2

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant